Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camelcase and pascalcase transformation logic #35

Merged
merged 1 commit into from
May 16, 2024

Conversation

42atomys
Copy link
Member

Description

In sprig, camelCase return a PascalCase and don't respect the separation logic between both functions.

Changes

  • Introduce a toPascalCase function to transform a string to a PascalCase
  • Fix the behivour of toCamelCase function to transform a string to a camelCase

Fixes Masterminds#328

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

Additional Information

This edit are related to Masterminds#328

Backport ticket from @ghostsquad

@42atomys 42atomys added type/bug 🔥 Something isn't working domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously aspect/dex 🤖 Concerns developers' experience with the codebase priority/medium 🟨 Priority 3 - Not blocking but should be fixed soon labels May 16, 2024
@42atomys 42atomys added this to the v1.0 milestone May 16, 2024
@42atomys 42atomys self-assigned this May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
strings_functions.go 100.0% <100.0%> (ø)

@42atomys 42atomys merged commit c6f4883 into main May 16, 2024
16 checks passed
@42atomys 42atomys deleted the fix/sprig-issue-328 branch May 16, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/dex 🤖 Concerns developers' experience with the codebase domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously priority/medium 🟨 Priority 3 - Not blocking but should be fixed soon type/bug 🔥 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of CamelCase is actually returning PascalCase
1 participant