dsn: add missing return

go-sql-driver · Oct 6, 2017 · 8d7c8b2 · 8d7c8b2
1 parent a7e960d
commit 8d7c8b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/dsn.go b/dsn.go
@@ -86,7 +86,7 @@ func (cfg *Config) normalize() error {
 		case "unix":
 			cfg.Addr = "/tmp/mysql.sock"
 		default:
-			errors.New("default addr for network '" + cfg.Net + "' unknown")
+			return errors.New("default addr for network '" + cfg.Net + "' unknown")
 		}
 
 	} else if cfg.Net == "tcp" {

diff --git a/dsn_test.go b/dsn_test.go
@@ -98,6 +98,7 @@ func TestDSNParserInvalid(t *testing.T) {
 		"(/",                          // no closing brace
 		"net(addr)//",                 // unescaped
 		"User:pass@tcp(1.2.3.4:3306)", // no trailing slash
+		"net()/",                      // unknown default addr
 		//"/dbname?arg=/some/unescaped/path",
 	}