Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL system variable example to README. #1077

Merged
merged 1 commit into from Jul 20, 2020

Conversation

nozawana44
Copy link
Contributor

Description

MySQL system variable tx_isolation is removed in MySQL 8.0. It is required to use transaction_isolation instead of tx_isolation.

transaction_read_only was added in MySQL 5.7.20 as an alias for tx_read_only, which is now deprecated and is removed in MySQL 8.0.

If tx_isolation is set into DSN params to use MySQL 8.0, an error occurs

$ go run main.go
Error 1193: Unknown system variable 'tx_isolation'

Checklist

omitted below because of updating only README.md

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@dolmen
Copy link
Contributor

dolmen commented Jul 9, 2020

"Improve README" is not a good commit message.

@methane
Copy link
Member

methane commented Jul 9, 2020

This is just an example of how to set system variables. Let's keep README simple.
Please just replace tx_isolation with transaction_isolation

@methane methane merged commit 73dc904 into go-sql-driver:master Jul 20, 2020
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants