Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update travis: use Go 1.14 for testing #1100

Merged
merged 4 commits into from
May 13, 2020
Merged

Update travis: use Go 1.14 for testing #1100

merged 4 commits into from
May 13, 2020

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented May 13, 2020

Description

This patch serie updates the Travis-CI configuration:

  • reverse the order of Go versions so recent versions are tested first (so we get failures on more recent version more quickly)
  • add Go 1.14.x
  • move testing against Go's tip branch just below Go 1.14.x as this is what matters the most after the latest production release
  • use Go 1.14.x instead of 1.10.x when testing with various versions of MySQL/MariaDB

Here is a build result: https://travis-ci.org/github/dolmen/mysql/builds/686640942

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

shogo82148
shogo82148 approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@shogo82148 shogo82148 merged commit f378f59 into go-sql-driver:master May 13, 2020
@dolmen
Copy link
Contributor Author

dolmen commented May 22, 2020

🎉 Thanks!

tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@dolmen @tz70s
Update travis: use Go 1.14 for testing (go-sql-driver#1100)
b83c140 
* Travis-CI: reverse order of Go version

Reverse order of Go versions so the recent ones are tested first.

* Travis-CI: add Go 1.14

* Travis-CI: move 'tip' just below the latest Go release

* Travis-CI: upgrade Go to 1.14 to run tests
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@dolmen @tz70s
Update travis: use Go 1.14 for testing (go-sql-driver#1100)
0c21234 
* Travis-CI: reverse order of Go version

Reverse order of Go versions so the recent ones are tested first.

* Travis-CI: add Go 1.14

* Travis-CI: move 'tip' just below the latest Go release

* Travis-CI: upgrade Go to 1.14 to run tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dolmen @shogo82148