Return ErrBadConn for invalid connections #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with #142 The database/sql package only retries if it encounters an ErrBadConn. With errInvalidConn it returns immediately
|
LGTM. Maybe we could cut it down a little with |
|
There is enough time to clean up the printf verbs after the v1.1 release |
julienschmidt
added a commit
that referenced
this pull request
Nov 2, 2013
Return ErrBadConn for invalid connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with #142
The database/sql package only retries if it encounters an ErrBadConn.
With errInvalidConn it returns immediately