Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: Add MySQL 5.7 and MariaDB tests. #560

Merged
merged 2 commits into from Mar 27, 2017
Merged

travis: Add MySQL 5.7 and MariaDB tests. #560

merged 2 commits into from Mar 27, 2017

Conversation

methane
Copy link
Member

@methane methane commented Mar 24, 2017

No description provided.

@methane
Copy link
Member Author

methane commented Mar 27, 2017

Could anyone review and merge this?
This only adds test environment on Travis-CI. Not touching code.

@julienschmidt
Copy link
Member

What exactly does this do? It tests every go version with every of the 3 configured mysql servers (mysql5.7, maria5.5, maria10.1)?

@julienschmidt julienschmidt added this to the v1.4 milestone Mar 27, 2017
@methane
Copy link
Member Author

methane commented Mar 27, 2017

@julienschmidt No. It only adds 3 tests.
MySQL 5.7, MariaDB 5.5 and MariaDB 10.1 are tested only with Go 1.8.
see this page: https://travis-ci.org/go-sql-driver/mysql/builds/214524497

@julienschmidt julienschmidt merged commit c1601d4 into go-sql-driver:master Mar 27, 2017
@julienschmidt julienschmidt mentioned this pull request Mar 27, 2017
Closed
@methane methane deleted the mariadb branch March 27, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
organization
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@methane @julienschmidt