Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could Client be a concrete implementation of an interface? #1138

Closed
danieljy opened this issue Aug 16, 2017 · 3 comments · Fixed by #2151
Closed

Could Client be a concrete implementation of an interface? #1138

danieljy opened this issue Aug 16, 2017 · 3 comments · Fixed by #2151

Comments

@danieljy
Copy link

This would allow for easy mocking out of clients.

Or is there a better way to do the mocking?

@casualjim
Copy link
Member

the transport is an interface. You can use a NOOP roundtripper

@thomasjungblut
Copy link

It would still be great to have the ability to use a mocking library to assert whether something was called, injecting failure and other nice stuff.

@fredbi
Copy link
Contributor

fredbi commented Jan 4, 2020

See pr #2151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants