Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errcheck failed on generated restapi/server.go#handleInterrupt #1689

Closed
c0va23 opened this issue Sep 9, 2018 · 0 comments · Fixed by #1715
Closed

errcheck failed on generated restapi/server.go#handleInterrupt #1689

c0va23 opened this issue Sep 9, 2018 · 0 comments · Fixed by #1715
Labels
generator good first issue

Comments

@c0va23
Copy link

c0va23 commented Sep 9, 2018

Not checked error returned from (*Server).Shutdown()

Steps to reproduce

go get -u github.com/kisielk/errcheck
errcheck $(go list ./...) | grep Shutdown
# print:
# restapi/server.go:499:14:       s.Shutdown()

Example of failed build: https://travis-ci.org/c0va23/redirector/builds/426186512#L691

Environment

swagger version: master
go version: any
OS: any

Template line:

go-swagger/generator/templates/server/server.gotmpl

Line 621 in b10bd7b

s.Shutdown()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
generator good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing error check on s.Shutdown() MrLuje/go-swagger
2 participants
@c0va23 @fredbi