Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff should detect extension value changes #2984

Closed
zmay2030 opened this issue Nov 8, 2023 · 1 comment
Closed

Diff should detect extension value changes #2984

zmay2030 opened this issue Nov 8, 2023 · 1 comment
Labels
diff Relates to the swagger diff command enhancement

Comments

@zmay2030
Copy link
Contributor

zmay2030 commented Nov 8, 2023 •
edited

Problem statement

PR #2935 added diff support for extensions, but it only covers when an extension key is added or removed. We should also report on changes in the extension value.

i.e: the following should be reported on in the diff output
Before

{
...
"x-ext-foo": "A"
...
}

After

{
...
"x-ext-foo": "B"
...
}
zmay2030 pushed a commit to zmay2030/go-swagger that referenced this issue Nov 9, 2023
fix: 1) adds supports for Diff to report on changed extension values g…
88aecb1 
…o-swagger#2984 and 2) detects request param extension changes go-swagger#2983

Signed-off-by: Ahmad Moudani <ahmad.moudani@crowdstrike.com>
@zmay2030 zmay2030 mentioned this issue Nov 9, 2023
Merged
@fredbi fredbi added enhancement diff Relates to the swagger diff command labels Dec 1, 2023
@fredbi
Copy link
Contributor

fredbi commented Dec 21, 2023

Fixed with #2986 merged. Closing.

@fredbi fredbi closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diff Relates to the swagger diff command enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zmay2030 @fredbi