Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responses dont have a stable order #846

Closed
clstb opened this issue Jan 5, 2017 · 3 comments · Fixed by #848
Closed

responses dont have a stable order #846

clstb opened this issue Jan 5, 2017 · 3 comments · Fixed by #848
Assignees
Labels

Comments

@clstb
Copy link

clstb commented Jan 5, 2017

Problem statement

When generating a client-sdk two times from the same spec responses dont have a stable order.
https://github.com/claasstoertenbecker/go-esi-link/commit/69176ecb74bcbb9f0a248458efa4b4eab9fb996c

Swagger specification

https://esi.tech.ccp.is/latest/swagger.json?datasource=tranquility

Steps to reproduce

1.) generate client sdk from spec
2.) do it again
3.) compare order of reponse files

@GlenDC
Copy link
Member

GlenDC commented Jan 5, 2017

The URL to your swagger.json file doesn't open. Can you please fix it, or upload the json file somewhere it can be seen by the parties interested?

@clstb
Copy link
Author

clstb commented Jan 5, 2017

Im sorry, the provider of the swagger.json just updated their k8s.
https://gist.github.com/claasstoertenbecker/88e2d4d0b52e4be8b128bcd199305745
Here you go.

@casualjim casualjim added the bug label Jan 6, 2017
GlenDC added a commit to Exient/go-swagger that referenced this issue Jan 7, 2017
@GlenDC GlenDC self-assigned this Jan 7, 2017
@GlenDC
Copy link
Member

GlenDC commented Jan 7, 2017

@claasstoertenbecker once #848 has been merged in (and this issue is closed), the order of your generated code should be consistent in sequential generations. The first time you'll generate with the latest swagger (that contains PR #848), you'll once again have a big diff, potentially bigger than ever. But all generations after that one should not suffer from this issue any longer.

Thanks for reporting this bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants