Junk pr #1580
Junk pr #1580
Conversation
intentionally bad change for golangci
|
well, this is highly embarrassing. My apologies. This works for me when I do it on my project :( For example, see here: nutanix/terraform-provider-nutanix#145 I'll open up an issue with the golangci team real quick. |
|
I've filed an issue on the central tracker for golangCI here to see if we can figure out why this isn't flagging (anything) in this pile of garbage PR - golangci/golangci#9 |
|
as you can see golangci is now required |
|
fantastic, thanks! Let's use this to drive to conclusion with upstream to figure out why its not doing what it should be doing |
|
They've got an issue with their service for this repo, they are fixing it per: golangci/golangci#9 (comment) |
| @@ -13,7 +13,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| package main | |||
|
|
|||
| package mainpackage mainpackage mainpackage mainpackage main | |||
There was a problem hiding this comment.
expected declaration, found 'package' (and 4 more errors)
| @@ -68,10 +82,10 @@ It aims to represent the contract of your API with a language agnostic descripti | |||
| if err != nil { | |||
| log.Fatal(err) | |||
| } | |||
|
|
|||
| s | |||
| _, err = parser.AddCommand("init", "initialize a spec document", "initialize a swagger spec document", &commands.InitCmd{}) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| log.Fatal(err)sdf |
|
As you guys can see, they fixed up the issue that I wrote about in the ticket on their system, and this is how they work for other PRs happy hunting! |
Alright, lets try this again, with even more junk and a proper golangci file