fix client cannot unmarshal struct which contains null

[alexz0000]

fixes #1729

[casualjim]

Can you run: go generate ./generator . that way bindata.go will get updated
We use this bindata: https://github.com/kevinburke/go-bindata

Can you also sign off on your commit? https://github.com/go-swagger/go-swagger/pull/1788/checks?check_run_id=30358019

[codecov]

Codecov Report

Merging #1788 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1788     +/-   ##
=========================================
+ Coverage   80.04%   80.14%   +0.1%     
=========================================
  Files          38       38             
  Lines        7497     7485     -12     
=========================================
- Hits         6001     5999      -2     
+ Misses       1019     1008     -11     
- Partials      477      478      +1

Impacted Files	Coverage Δ
generator/bindata.go	68.34% <100%> (+1.61%)	⬆️
generator/template_repo.go	87.43% <0%> (-0.97%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800a305...18394a2. Read the comment docs.

[casualjim]

Can you please run: go generate ./generator?
That way generator/bindata.go will get updated, and your changes will actually get picked up.
We use this bindata: https://github.com/kevinburke/go-bindata

[alexz0000]

Done, thanks

[alexz0000]

Hi @casualjim, Does the failed test cases means I don't have the permission to update the template?

[casualjim]

I think it means that the assertion is for propNodes, err := Unmarshal... but the code has nodes, err := Unmarshal...

[fredbi]

the prop prefix was added to avoid naming conflicts

[alexz0000]

the nodes is just a tmp variable, I think it's OK here to use nodes, err := Unmarshal..., what do you think?

[casualjim]

I think irrespective of the naming discussion, the test isn't passing, so the test needs an updated assertion. You can run the tests with go test ./generator/...

[fredbi]

the nodes is just a tmp variable, I think it's OK here to use nodes, err := Unmarshal..., what do you think?

Don't. How about a field named err?

[alexz0000]

I updated the cases, could you help to review and merge the code ?