Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow '?' character in route path #1792

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Conversation

andrewmilson
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #1792 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   80.48%   80.04%   -0.45%     
==========================================
  Files          38       38              
  Lines        7544     7497      -47     
==========================================
- Hits         6072     6001      -71     
- Misses        996     1019      +23     
- Partials      476      477       +1
Impacted Files Coverage Δ
scan/scanner.go 72.05% <ø> (ø) ⬆️
generator/client.go 68.18% <0%> (-11.45%) ⬇️
generator/shared.go 80.74% <0%> (-2.91%) ⬇️
generator/bindata.go 66.73% <0%> (-1.62%) ⬇️
generator/types.go 90.84% <0%> (ø) ⬆️
generator/debug.go 100% <0%> (ø) ⬆️
cmd/swagger/commands/generate/client.go 100% <0%> (ø) ⬆️
generator/model.go 84.32% <0%> (+0.12%) ⬆️
scan/parameters.go 78.37% <0%> (+0.14%) ⬆️
generator/operation.go 89.33% <0%> (+0.2%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953c904...61d94ee. Read the comment docs.

@casualjim
Copy link
Member

@fredbi fredbi changed the title Allow '?' charachter in route path's Allow '?' character in route path Nov 17, 2018
@casualjim casualjim merged commit c44e54d into go-swagger:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants