Use JSON for examples of type object #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon-barrett
force-pushed
the
leon/object-example
branch
from
8db5445
to
5fdb928
Compare
The OpenAPI 2.0 spec allows examples to be any JSON value. Currently, go-swagger supports most types (e.g. ints and strings), but not objects. This adds support to parse object examples as JSON, allowing users to document examples for maps. Signed-off-by: Leon Barrett <leon@cogitai.com>
leon-barrett
force-pushed
the
leon/object-example
branch
from
5fdb928
to
6fb3fbc
Compare
casualjim
approved these changes
Nov 17, 2018
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
- Coverage 80.13% 80.07% -0.06%
==========================================
Files 38 38
Lines 7489 7494 +5
==========================================
Hits 6001 6001
- Misses 1009 1014 +5
Partials 479 479
Continue to review full report at Codecov.
|
|
Could you please add some unit test to assert this behaves as expected? |
|
there is a test already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAPI 2.0 spec allows examples to be any JSON value. Currently,
go-swagger supports most types (e.g. ints and strings), but not objects.
This adds support to parse object examples as JSON, allowing users to
document examples for maps.