Deprecates --with-context option
#1806
Conversation
| s := Server{ | ||
| WithContext: true, | ||
| } | ||
| s.getOpts() |
There was a problem hiding this comment.
Error return value of s.getOpts is not checked
Codecov Report
@@ Coverage Diff @@
## master #1806 +/- ##
==========================================
- Coverage 80.48% 80.47% -0.02%
==========================================
Files 38 38
Lines 7543 7539 -4
==========================================
- Hits 6071 6067 -4
Misses 996 996
Partials 476 476
Continue to review full report at Codecov.
|
fredbi
force-pushed
the
fix-1684
branch
3 times, most recently
from
cf8eee3
to
5e6c30d
Compare
The command line flags remains active (older CLI scripts still work), but the flag is ignored. Templates are cleaned up from this unsupported variant, including stratoscale. * fixes go-swagger#1684 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
|
Sorry for commenting on an old PR, but SEO results were not helpful to figure this out. This is a top result when searching for the deprecated command line flag What's the way to generate handlers such that they can access the current request context? |
|
You can get the request context from the |
|
Amazing, I missed that! Thanks again @casualjim ! |
The command line flags remains active (older CLI scripts still work),
but the flag is ignored.
Templates are cleaned up from this unsupported variant, including stratoscale.
Signed-off-by: Frederic BIDON fredbi@yahoo.com