feat(diff): introducing warning compatibility level #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am open to a better name than "Warning" as "Warning changes" doesn't seem appropriate. |
|
Warn is also what's used in other similar tools, like code linters etc. I think this can be expanded upon for users to allow uplifting warnings to errors |
casualjim
approved these changes
Apr 28, 2023
casualjim
force-pushed
the
warning-level-impl-2932
branch
from
295a87b
to
fb2690b
Compare
Signed-off-by: Suraj Chafle <suraj.chafle@crowdstrike.com>
|
You could maybe rename it to something like: UserImpacting if you prefer but for me Warn is also fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a new compatibility level warning. Warning should be used for changes which are technically non-breaking but can cause behavior changes on client.
Implements #2932