fix(validations): fixed MinProperties/MaxProperties #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
approved these changes
Dec 30, 2023
* fixes go-swagger#2587 This PR fixes some cases in which the Min/MaxProperties were wrongly evaluated: * case of a property which is a map (issue go-swagger#2587) * case of a property which is an array (non reported issue) * edge case of a map representing an object with additionalProperties: false and a enum validation Other fixes: * fixed duplicate or missing Min/MaxProperties documentation in docstrings * whenever a min/maxProperties validation is present, if no additional properties key is provided, assume "additionalProperties: true" * Tests * added more assertions for existing test cases involving min/max properties (go-swagger#2444, go-swagger#2163) * added codegen assertions with an extended version of the spec provided with issue go-swagger#2587 This PR introduces some context to GenSchema, namely IsElem and IsProperty, to allow templates to take better informed decisions. At this moment, this is only used by the minmaxproperties validation template. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix/2587-maxProperties
branch
from
eb3ff87
to
8cebfb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxPropertiesis generated incorrectly #2587This PR fixes some cases in which the Min/MaxProperties were wrongly evaluated:
maxPropertiesis generated incorrectly #2587)Other fixes:
fixed duplicate or missing Min/MaxProperties documentation in docstrings
whenever a min/maxProperties validation is present, if no additional properties key is provided, assume "additionalProperties: true"
Tests
maxPropertiesis generated incorrectly #2587This PR introduces some context to GenSchema, namely IsElem and IsProperty, to allow templates to take better informed decisions. At this moment, this is only used by the minmaxproperties validation template.