fix(validations): fixed missing validation in embedded structs #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
approved these changes
Dec 30, 2023
* fixes go-swagger#2604 This PR fixes the empty Validate methods generated when generating embedded structs (that is, when an object redefines another object with a $ref). Since the actual need for validation is not known when hitting the embedded struct, always assume a validation. Exception: when the embedded type is interface{} or io.Reader, we know that we should not call Validate. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix/2604-embedded-models
branch
from
6ee8e4c
to
a1104a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the empty Validate methods generated when generating embedded structs (that is, when an object redefines another object with a $ref).
Since the actual need for validation is not known when hitting the embedded struct, always assume a validation.
Exception: when the embedded type is interface{} or io.Reader, we know that we should not call Validate.