Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: setup ossf scorecard and codql workflows" #3056

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

casualjim
Copy link
Member

Reverts #3049

@fredbi
Copy link
Contributor

fredbi commented Jan 6, 2024

@casualjim I am proposing to take care of this by reverting more selectively.

  1. tame dependabot to avoid the overwhelming flurry of PRs
    • monthly scans, automatic approve&merge with minimal CI when only github actions are involved
  2. remove the score card. The results cannot be viewed anyway (the link under the badge does not work)
  3. keep the github code scan (at least for some time). It is always interesting to watch if something interesting comes out of it

Overall we agree on principle: let's not allow this thing to become a work generator.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (479c51b) 32.55% compared to head (b6b31b0) 82.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3056       +/-   ##
===========================================
+ Coverage   32.55%   82.64%   +50.09%     
===========================================
  Files          60       62        +2     
  Lines       12803    12856       +53     
===========================================
+ Hits         4168    10625     +6457     
+ Misses       8296     1692     -6604     
- Partials      339      539      +200     
Flag Coverage Δ
codegen-oldstable-canary-fixtures 32.55% <ø> (ø)
codegen-stable-canary-fixtures 32.55% <ø> (ø)
unit-oldstable 82.79% <ø> (?)
unit-stable 82.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi
Copy link
Contributor

fredbi commented Jan 7, 2024

@casualjim I've resolved the merge conflict and re-added 2 things that I've found interesting to continue experimenting with: the codeSQL scan and the "security score cards" (a kind of linter for "opsec best practices). The report is eventually available (it took a day to set up, but now it's there) and the findings, if not necessarily relevant to our use-case, are interesting to analyze and be reflected upon.

https://securityscorecards.dev/viewer/?uri=github.com/go-swagger/go-swagger

Maybe we'll eventually decide to disable this scorecard if it turns out to be really not suited to our project, but for the moment I am still curious about the recommendations.

I've removed dependabot and the by-commit-sha pinning for now. I think that @mmorel-35 raised an interesting point, but the PR did not come with a complete solution, just more problems to solve in the short term and more work until we find an appropriate solution to maintain our dependencies with minimal burden. So, statu quo for now, I need more experimentation on my fork.

@mmorel-35 I have to thank you for having raised an interesting point. However yesterday's experiment proved not to be very successful: as soon as the stuff was merged, we already had about 5 such update PRs, stalling all our CI for hours.

This started a fascinating conversation with @casualjim about the extra workload that comes from all those update bots...

If we eventually move to such kind of automation, it will have to be more carefully designed and discussed beforehand.

Another contributor has suggested a dependabot setup to some of the go-openapi repos. The problem to solve for those repos is different, but still, we don't want to use many different tools.

@fredbi
Copy link
Contributor

fredbi commented Jan 7, 2024

NOTE: I've updated those damned actions, so the bot PR's should disappear automatically.

casualjim and others added 2 commits January 8, 2024 11:40
* The main disagreement on #3049 came from dependabot
* codeql scan and score card are thought as desirable additions

dependabot triggered a lot of PRs and overall, generates a lot of
extra work for the maintainers.

We need extra care and testing before introducing a dependency update
bot that understands our dependencies, may be coupled with auto
approval and auto merge, and may skip long running integration tests
when they are irrelevant. This work is deferred to a forthcoming PR.

The pinning of build dependencies (github actions, docker base images)
is reverted until we set out for a proper update process to
automatically update them with an appropriate frequency.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi merged commit 70c3781 into master Jan 8, 2024
29 of 30 checks passed
@fredbi fredbi deleted the revert-3049-ossf branch January 8, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants