chore: updated dependencies for examples #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3057 +/- ##
==========================================
- Coverage 82.65% 82.64% -0.01%
==========================================
Files 62 62
Lines 12856 12856
==========================================
- Hits 10626 10625 -1
- Misses 1691 1692 +1
Partials 539 539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mmorel-35
reviewed
Jan 7, 2024
fredbi
force-pushed
the
test/check-examples-build
branch
2 times, most recently
from
94e0c16
to
ab8dc0d
Compare
fredbi
force-pushed
the
test/check-examples-build
branch
from
ab8dc0d
to
dadb3c7
Compare
fredbi
changed the title
fredbi
force-pushed
the
test/check-examples-build
branch
2 times, most recently
from
b8643be
to
7dd7179
Compare
* updated dependencies for oauth2 examples: oidc and jwt new versions came with breaking changes * ci: added build check for examples > NOTE: initially, I wanted to reduce the set of main dependencies by making the "examples" folder > it own module. Eventually, this did not change much (apart oidc and jwt) > and was adding more maintainance burden. Given up on that. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
test/check-examples-build
branch
from
7dd7179
to
c1a3b10
Compare
mmorel-35
reviewed
Jan 25, 2024
| @@ -58,6 +58,12 @@ jobs: | |||
| run: | | |||
| go install ./cmd/swagger | |||
|
|
|||
| - name: Verify that examples build | |||
There was a problem hiding this comment.
Don't you think it could deserve it's own job in the workflow with a dedicated step for each these commands ?
There was a problem hiding this comment.
I don't know. This would require a "workflow_run" trigger to operate after the previous steps, but yes, essentually why not? If you feel strongly about that, please propose a follow-up PR.
youyuanwu
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
came with breaking changes
Signed-off-by: Frederic BIDON fredbi@yahoo.com