Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record adding and removing schema from response in swagger diff #3074 #3075

Conversation

zmay2030
Copy link
Contributor

@zmay2030 zmay2030 commented Mar 2, 2024

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.53%. Comparing base (bcc7c78) to head (def0584).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3075      +/-   ##
==========================================
+ Coverage   19.49%   19.53%   +0.03%     
==========================================
  Files         646      644       -2     
  Lines       54504    54449      -55     
==========================================
+ Hits        10625    10635      +10     
+ Misses      43340    43275      -65     
  Partials      539      539              
Flag Coverage Δ
codegen-oldstable-canary-fixtures 32.51% <0.00%> (-0.04%) ⬇️
codegen-stable-canary-fixtures 32.51% <0.00%> (-0.04%) ⬇️
unit-oldstable 82.81% <100.00%> (+0.01%) ⬆️
unit-stable 19.42% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…agger#3074

Signed-off-by: Ahmad Moudani <ahmad.moudani@crowdstrike.com>
@fredbi fredbi force-pushed the record-adding-or-removing-schema-from-response branch from 67f14a5 to def0584 Compare March 4, 2024 14:41
@fredbi fredbi added the diff Relates to the swagger diff command label Mar 4, 2024
@fredbi
Copy link
Contributor

fredbi commented Mar 4, 2024

@zmay2030 LGTM. I've rebased your branch after having merge a fix for broken CI. Merging now.

@fredbi fredbi merged commit 0dc44b6 into go-swagger:master Mar 4, 2024
28 checks passed
@zmay2030
Copy link
Contributor Author

@fredbi thank you. It's been a while since a new release has been pushed out, any chance we can do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff Relates to the swagger diff command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding or removing a schema from response is not being recorded in the diff
2 participants