Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate & gorm-gen #6

Closed
wants to merge 13 commits into from
Closed

feat: migrate & gorm-gen #6

wants to merge 13 commits into from

Conversation

cexll
Copy link
Contributor

@cexll cexll commented Jul 24, 2023 •
edited
Loading

feature

  1. sql migration
  2. data migration
  3. gorm-gen

github-actions[bot]
github-actions bot reviewed Jul 24, 2023
View reviewed changes
core/str/str.go Outdated

func StrContainsChinese(str string) (exists bool) {
rs := []rune(str)
for _, r := range rs {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <S1029> reported by reviewdog 🐶
should range over string, not []rune(string)

core/str/str.go Outdated

func StrContainsChinese(str string) (exists bool) {
rs := []rune(str)
for _, r := range rs {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <SA6003> reported by reviewdog 🐶
should range over string, not []rune(string)

@cexll cexll closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cexll