Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install global bin to the correct location on windows #5

Merged
merged 2 commits into from
May 28, 2023
Merged

Install global bin to the correct location on windows #5

merged 2 commits into from
May 28, 2023

Commits on May 24, 2023

  1. Add a test to get the correct global bin installation path on Windows

    @sounisi5011
    sounisi5011 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e1591df View commit details
    Browse the repository at this point in the history

  2. Install global bin to the correct location on Windows 

    On Windows, the globally installed CLI is placed in the `%npm_config_prefix%` directory, not the `%npm_config_prefix%\bin` directory.

> When in global mode, executables are linked into `{prefix}/bin` on Unix,
> or directly into `{prefix}` on Windows.  Ensure that path is in your
> terminal's `PATH` environment to run them.
> --- https://github.com/npm/cli/blob/1e977eec223463b04a6ad2c1953e31a6d5d22f2c/docs/lib/content/configuring-npm/folders.md?plain=1#L55-L57

This pull request fixes a bug that did not conform to this behavior.

Closes go-task#4
    @sounisi5011
    sounisi5011 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4d60bbd View commit details
    Browse the repository at this point in the history