fix: add changelog + fix for booleans for #1641

go-task · May 9, 2024 · bfc9d78 · bfc9d78
1 parent 3397f28
commit bfc9d78
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased
+
+- Fix bug where non-string values (numbers, bools) added to `env:` weren't been
+  correctly exported (#1640, #1641 by @vmaerten and @andreynering).
+
 ## v3.37.0 - 2024-05-08
 
 - Released the

diff --git a/internal/env/env.go b/internal/env/env.go
@@ -29,7 +29,7 @@ func Get(t *ast.Task) []string {
 
 func isTypeAllowed(v any) bool {
 	switch v.(type) {
-	case string, int, float32, float64:
+	case string, bool, int, float32, float64:
 		return true
 	default:
 		return false

diff --git a/task_test.go b/task_test.go
@@ -103,7 +103,7 @@ func TestEnv(t *testing.T) {
 		Files: map[string]string{
 			"local.txt":         "GOOS='linux' GOARCH='amd64' CGO_ENABLED='0'\n",
 			"global.txt":        "FOO='foo' BAR='overriden' BAZ='baz'\n",
-			"multiple_type.txt": "FOO='1' BAR='' BAZ='1.1'\n",
+			"multiple_type.txt": "FOO='1' BAR='true' BAZ='1.1'\n",
 		},
 	}
 	tt.Run(t)