Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powershell completion: disable file path autocomplete / add flags #1168

Merged
merged 19 commits into from
May 23, 2023
Merged

powershell completion: disable file path autocomplete / add flags #1168

merged 19 commits into from
May 23, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 15, 2023

Thanks for your pull request, we really appreciate contributions!

Please understand that it may take some time to be reviewed.

Also, make sure to follow the Contribution Guide.

Didn't know there is a command task --list-all --json/--silent for all available tasks when I submit last PR.

Previous, if your pwd have a dir or file named gen or gen..., and you have a task named gen,
when you type task gen<tab>, powershell will fallback to filepath complete, and your input will become task .\gen

after this pr, task gen<tab> are still task gen

File path auto completion still works with .\<tab> or ./<tab>

@trim21 trim21 marked this pull request as draft May 15, 2023 20:36
@trim21 trim21 changed the title powershell completion: regex is not needed anymore powershell completion: disable file path autocomplete May 15, 2023
@trim21 trim21 marked this pull request as ready for review May 15, 2023 20:54
@trim21 trim21 changed the title powershell completion: disable file path autocomplete powershell completion: disable file path autocomplete and add more options May 15, 2023
@trim21
Copy link
Contributor Author

trim21 commented May 15, 2023

I try to add short opt but looks like old powershell (5.1, win10 default version) doesn't work will with that, So I'll just add long flags.

@trim21 trim21 marked this pull request as draft May 15, 2023 23:41
@trim21
Copy link
Contributor Author

trim21 commented May 15, 2023

adding description feature, convert to draft

@trim21 trim21 marked this pull request as ready for review May 15, 2023 23:58
@trim21 trim21 changed the title powershell completion: disable file path autocomplete and add more options powershell completion: disable file path autocomplete, add flags and add descriptions May 16, 2023
@trim21 trim21 changed the title powershell completion: disable file path autocomplete, add flags and add descriptions powershell completion: disable file path autocomplete, add flags May 16, 2023
@trim21
Copy link
Contributor Author

trim21 commented May 16, 2023

description feature make it much slower to finish completion ( caused by parsing json ), so I removed it.

@trim21 trim21 changed the title powershell completion: disable file path autocomplete, add flags powershell completion: disable file path autocomplete / add flags May 16, 2023
@andreynering
Copy link
Member

Thanks!

@andreynering andreynering merged commit f0e9751 into go-task:main May 23, 2023
@trim21 trim21 deleted the patch-1 branch May 23, 2023 00:48
@pd93 pd93 mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants