[3.35.0 regression] Precondition scripts no longer working

[ReillyBrogan]

• Task version: 3.35.0
• Operating system: Linux (Solus)
• Experiments enabled: N/A

I was updating the Solus go-task package to v3.35.0, and while testing it I noticed that there was a regression in that a script that we had as a precondition of a task stopped working. This worked on v3.34.1, so this is a regression specific to v3.35.0

We have a task for publishing packages that looks like the following:

  publish:
    desc: Tag and publish a release
    dir: '{{ .USER_WORKING_DIR }}'
    preconditions:
      - sh: test $(git symbolic-ref HEAD 2>/dev/null) = "refs/heads/main"
        msg: Not on main branch
      - sh: "{{ .TASKFILE_DIR }}/common/Scripts/package-publish-safety-catches.sh"
        msg: Failed to pass safety catches
    deps:
      - package-file
    cmds:
      - git push
      - task: push

The package-publish-safety-catches.sh script is available here.

When this task is called it now always errors out with the following error:

task: Failed to pass safety catches
task: precondition not met

When the script is ran directly it runs without issue and exits with a 0 status code (IE, indicating that none of the conditions that it's designed to detect are present). I tested both Fish shell and Bash to see if it made a difference and both had the same error. In case it matters we are building with golang 1.22.0. I also tested the official v3.35.0 binaries from Github and they exhibit the same behavior.

Bisecting this reveals that the bad commit is bb9d582.

[pd93]

Hi @ReillyBrogan. Thanks for reporting. I see that you're using dir: '{{ .USER_WORKING_DIR }}'. Are you running Task from a directory other than the directory containing the Taskfile? It would help me to understand what directory you're running the command from and where the Taskfile is relative to this. Thanks

[ReillyBrogan]

Hi @ReillyBrogan. Thanks for reporting. I see that you're using dir: '{{ .USER_WORKING_DIR }}'. Are you running Task from a directory other than the directory containing the Taskfile? It would help me to understand what directory you're running the command from and where the Taskfile is relative to this. Thanks

Yes, our Taskfile lives in the root of our repo. For the task with the issue we would indeed call go-task in a sub-directory.