fix: taskfile directory #1530
Merged
fix: taskfile directory #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1529
This issue was caused by a change in #1483 that moved where the Taskfile directory was calculated. This resulted in Task behaving weirdly in situations where a Taskfile is located in a parent directory to the user's current working directory. This was partly fixed in #1522. However, the core issue still remained.
This PR fixes any remaining related issues by moving the directory calculation entirely into the
NewRootNode()function and then fetching the calculated dir from the resulting node ine.Setup(). The node creation has also been moved earlier in the executor setup in order to fix another unreported bug where the temporary.taskdirectory was created in the wrong place.