Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle int and float env variable by converting them to string #1641

Merged
merged 1 commit into from
May 9, 2024

Conversation

vmaerten
Copy link
Collaborator

@vmaerten vmaerten commented May 9, 2024

Hey @pd93,

I've tried a solution to fix :

It's because since the any vars, some vars are detected as int or float and do not get added to the env map.
So we can let them passthrough and convert them with %v

I've also added a test to convert this case

@andreynering andreynering merged commit 3397f28 into go-task:main May 9, 2024
13 checks passed
@andreynering
Copy link
Member

Thanks @vmaerten!

I did an additional fix to make booleans work as well: bfc9d78

v3.37.1 will be released soon.

@andreynering andreynering added type: bug Something not working as intended. area: env Changes related to environment variables. labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: env Changes related to environment variables. type: bug Something not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants