Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal handling for subprocess #479

Merged
merged 6 commits into from May 14, 2022

Commits on Apr 28, 2021

  1. add regression test for SIGINT behavior

    See go-task/task/go-task#458
    
    Helper (sleepit) and test code based on https://github.com/marco-m/timeit
    marco-m authored and marco-m-pix4d committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    a496a75 View commit details
    Browse the repository at this point in the history
  2. execext.RunCommand: fix: do not pass a cancellable context to mvdan.c…

    …c/sh
    
    We used to pass to mvdan.cc/sh/interp.Runner a context that was cancelled on
    reception of a OS signal. This caused the Runner to terminate the subprocess
    abruptly.
    
    The correct behavior instead is for us to completely ignore the signal and let
    the subprocess deal with it. If the subprocess doesn't handle the signal, it
    will be terminated. If the subprocess does handle the signal, it knows better
    than us wether it wants to cleanup and terminate or do something different.
    
    So now we pass an empty context just to make the API of interp.Runner happy
    
    Fixes go-task/task/go-task#458
    marco-m authored and marco-m-pix4d committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    86a2185 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Configuration menu
    Copy the full SHA
    793f9d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. fix ci test breakage (fork/exec ./bin/task: no such file or directory)

    On Github actions, the destination path of "go install" ($GOPATH/bin) is not
    in $PATH, thus the error.
    For the life of me I could not understand how to change the $PATH environment
    variable in an Actions workflow, so I encode the full path of the just-built
    task executable in the tests, which probably was the right thing to do since
    the beginning.
    marco-m-pix4d committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    3eb5840 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Configuration menu
    Copy the full SHA
    b76ef73 View commit details
    Browse the repository at this point in the history
  2. fix: remove redundant newline (linter error)

    aliculPix4D committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    551d439 View commit details
    Browse the repository at this point in the history