Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrays are not properly compared #12

Closed
samlitowitz opened this issue Jan 23, 2018 · 5 comments
Closed

Arrays are not properly compared #12

samlitowitz opened this issue Jan 23, 2018 · 5 comments

Comments

@samlitowitz
Copy link

samlitowitz commented Jan 23, 2018 •
edited

Arrays content is not compared, for instance deep.Equal([3]int{1, 2, 3}, [3]int{}) == nil is true.
@samlitowitz samlitowitz mentioned this issue Jan 23, 2018
Merged
@daniel-nichter
Copy link
Member

Thanks for reporting. I'm surprised there's not a test case for that already. Want to write one that reproduces the issue?

@samlitowitz
Copy link
Author

samlitowitz commented Jan 23, 2018 •
edited

It is part of PR #13, located here.

@daniel-nichter
Copy link
Member

Awesome, thanks! I see now: I was thinking "slice", for which there are tests, but this is about arrays. Thanks for the fix! I'll tag and release v1.0.1.

@pcasaretto
Copy link

pcasaretto commented Jan 26, 2018 •
edited

Just got bit by this :)
Waiting for the release.

@daniel-nichter
Copy link
Member

v1.0.1 tagged/released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pcasaretto @daniel-nichter @samlitowitz