-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch human logging to stderr to enable pipeable validation output #416
Conversation
N.b. I did this with github.dev so no idea if the tests work… it was a copy-paste job for the stdout -> stderr impl |
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 86.00% 86.04% +0.03%
==========================================
Files 132 133 +1
Lines 5754 5768 +14
==========================================
+ Hits 4949 4963 +14
Misses 660 660
Partials 145 145
|
I'm trying to write a pre-commit hook and stumbled upon this muddying the YAML output from |
@colindean So is the point of this PR to have the entire |
If I had it my way:
This PR accomplishes the first two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple typos. Tested this locally:
vela validate pipeline | yq -j
Error: bad file '-': yaml: line 2: mapping values are not allowed in this context
vs.
~/.../cli/release/darwin/amd64/vela validate pipeline | yq -j
{
"version": "1",
"metadata": {
"clone": false,
"environment": [
"steps",
"services",
"secrets"
]
},
.... etc
Nice
Co-authored-by: Easton Crupper <65553218+ecrupper@users.noreply.github.com>
Work toward go-vela/community#313