Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: on_start failures should result in a step error #850

Closed
plyr4 opened this issue Aug 21, 2023 · 0 comments · Fixed by go-vela/worker#527
Closed

worker: on_start failures should result in a step error #850

plyr4 opened this issue Aug 21, 2023 · 0 comments · Fixed by go-vela/worker#527
Assignees
@timhuynh94
Labels
bug Indicates a bug

Comments

@plyr4
Copy link
Contributor

plyr4 commented Aug 21, 2023

Description

see title, if a step has pull: on_start and it fails to pull, it should that step as a failure. right now it results in a success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timhuynh94 timhuynh94

Labels
bug Indicates a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(step): set step error for on_start failure using bad image go-vela/worker
2 participants
@timhuynh94 @plyr4