Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs for pipeline validation #241

Merged
merged 5 commits into from
Oct 23, 2021
Merged

feat: add docs for pipeline validation #241

merged 5 commits into from
Oct 23, 2021

Conversation

kneal
Copy link
Contributor

@kneal kneal commented Aug 6, 2021

No description provided.

@kneal kneal requested a review from a team as a code owner August 6, 2021 17:50
@kneal kneal self-assigned this Aug 6, 2021
@kneal kneal added the feature Indicates a new feature label Aug 6, 2021
@kneal kneal added this to In progress in Sprint 1 (0.9.0) via automation Aug 6, 2021
@kneal kneal moved this from In progress to PR open in Sprint 1 (0.9.0) Aug 6, 2021
@susangreve susangreve added this to PR open in Sprint 2 (0.10.0) Aug 9, 2021
@susangreve susangreve removed this from PR open in Sprint 2 (0.10.0) Sep 1, 2021
@susangreve susangreve added this to PR open in Sprint 3 (0.10.0) Sep 1, 2021
jbrockopp
jbrockopp previously approved these changes Sep 27, 2021
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r
Copy link
Collaborator

wass3r commented Sep 27, 2021

we might want to put this into draft mode until go-vela/cli#248 is merged.

@wass3r wass3r marked this pull request as draft September 27, 2021 17:12
KellyMerrick
KellyMerrick previously approved these changes Oct 11, 2021
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

correction: found a small mistake and will submit a fix momentarily

@KellyMerrick KellyMerrick dismissed stale reviews from jbrockopp and themself via c34acb1 October 11, 2021 13:49
@wass3r wass3r marked this pull request as ready for review October 18, 2021 15:54
@wass3r wass3r marked this pull request as draft October 18, 2021 15:55
@wass3r
Copy link
Collaborator

wass3r commented Oct 18, 2021

i think this is good to go as soon as we cut a release on CLI 👍🏼

@kneal kneal marked this pull request as ready for review October 18, 2021 16:01
@wass3r wass3r merged commit b156b57 into master Oct 23, 2021
Sprint 3 (0.10.0) automation moved this from PR open to Done Oct 23, 2021
@wass3r wass3r deleted the feat/work_w_tmpl branch October 23, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants