-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docs for new render inline option #291
Conversation
content/reference/yaml/metadata.md
Outdated
|-----------------|----------|------|--------------------------------------------------------| | ||
| `template` | Y | bool | Enables compiling the pipeline as a template. | | ||
| `clone` | N | bool | Enables injecting the default clone process. | | ||
| `render_inline` | N | bool | Enables rendering for templates without stages/steps. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think this description is quite accurate? you can have either as long as the template has the same (ie. template injects stages, your base pipeline needs to have stages too). in fact, should that factoid be called out somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's what it can do but probably not phrased in the correct spot. It's weird because the work was done in the story to enable Stages for templates but the feature does that indirectly by unlocking many more features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'll merge as is and amend after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ie. template injects stages, your base pipeline needs to have stages too)
The examples provided in the other file are stages injections. I would hope that would be intuitive enough to show that stages can be templated but I suppose we could be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh. This looks like a sweet feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Related to: go-vela/community#233