enhance(api/workers): add filters to list workers #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
+ Coverage 66.96% 67.00% +0.04%
==========================================
Files 330 330
Lines 14074 14075 +1
==========================================
+ Hits 9424 9431 +7
+ Misses 4169 4165 -4
+ Partials 481 479 -2
|
timhuynh94
previously approved these changes
Dec 28, 2023
claire1618
previously approved these changes
Dec 28, 2023
wass3r
reviewed
Dec 29, 2023
wass3rw3rk
previously requested changes
Dec 29, 2023
timhuynh94
previously approved these changes
Jan 2, 2024
wass3r
reviewed
Jan 2, 2024
wass3r
approved these changes
Jan 2, 2024
claire1618
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be helpful to add these query parameters for listing workers. I was using
vela get workersCLI command the other day and trying to do some bash scripting to filter out stale workers and it made me want to do this 😅