-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stage): add environment field #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 96.71% 96.73% +0.02%
==========================================
Files 53 53
Lines 5595 5644 +49
==========================================
+ Hits 5411 5460 +49
Misses 137 137
Partials 47 47
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test here for this YAML functionality?
Specifically, with regards to unmarshalling YAML for stages
with an environment
block?
I think updating the existing test would work so here are the locations for reference:
Line 173 in 87c103b
func TestYaml_StageSlice_UnmarshalYAML(t *testing.T) { |
https://github.com/go-vela/types/blob/feat/add-stage-environment/yaml/testdata/stage.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Adding an environment map to the stage environment. I've worked on the server functionality and did not end up using the MergeEnv function that I copied over from
step
, but I figured adding the same function to the stage object would be good for future use if the need were to arise.