Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stage): add environment field #215

Merged
merged 5 commits into from
Dec 22, 2021
Merged

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Dec 7, 2021

Related Issue

Adding an environment map to the stage environment. I've worked on the server functionality and did not end up using the MergeEnv function that I copied over from step, but I figured adding the same function to the stage object would be good for future use if the need were to arise.

@ecrupper ecrupper requested a review from a team as a code owner December 7, 2021 19:58
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #215 (7a91e85) into master (28210cf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   96.71%   96.73%   +0.02%     
==========================================
  Files          53       53              
  Lines        5595     5644      +49     
==========================================
+ Hits         5411     5460      +49     
  Misses        137      137              
  Partials       47       47              
Impacted Files Coverage Δ
pipeline/stage.go 100.00% <100.00%> (ø)
yaml/stage.go 100.00% <100.00%> (ø)

pipeline/stage.go Outdated Show resolved Hide resolved
pipeline/stage.go Outdated Show resolved Hide resolved
pipeline/stage.go Outdated Show resolved Hide resolved
pipeline/stage.go Outdated Show resolved Hide resolved
pipeline/stage.go Outdated Show resolved Hide resolved
pipeline/stage.go Outdated Show resolved Hide resolved
yaml/stage.go Outdated Show resolved Hide resolved
yaml/stage.go Outdated Show resolved Hide resolved
yaml/stage.go Outdated Show resolved Hide resolved
yaml/stage.go Outdated Show resolved Hide resolved
@jbrockopp jbrockopp added the feature Indicates a new feature label Dec 20, 2021
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test here for this YAML functionality?

Specifically, with regards to unmarshalling YAML for stages with an environment block?

I think updating the existing test would work so here are the locations for reference:

func TestYaml_StageSlice_UnmarshalYAML(t *testing.T) {

https://github.com/go-vela/types/blob/feat/add-stage-environment/yaml/testdata/stage.yml

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecrupper ecrupper merged commit 3b10955 into master Dec 22, 2021
@ecrupper ecrupper deleted the feat/add-stage-environment branch December 22, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants