enhance(webhook): enable skipping builds during tag events #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 96.73% 96.74%
=======================================
Files 53 53
Lines 5644 5645 +1
=======================================
+ Hits 5460 5461 +1
Misses 137 137
Partials 47 47
|
jbrockopp
reviewed
Dec 20, 2021
Comment on lines
+34
to
+36
| // push or tag event | ||
| // nolint: lll // ignore long line length due to if logic | ||
| if strings.EqualFold(constants.EventPush, w.Build.GetEvent()) || strings.EqualFold(constants.EventTag, w.Build.GetEvent()) { |
There was a problem hiding this comment.
This change LGTM so I already approved 👍
However, wanted to throw out a question as a discussion for future reviewers.
Is there an appetite to remove the event parsing logic completely?
This would expose the skip functionality to all event types rather than just push and tag.
There was a problem hiding this comment.
i think that's fine?! i guess it's only there to lock conditions to known scenarios. for example, i don't know if the commit is null for other events that we want to process, ie. comments? we're probably good, but that would be going through my head.
wass3r
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: go-vela/community#454