Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting --force-build-metadata flag for /kaniko/executor #102

Merged
merged 7 commits into from
Feb 18, 2022

Conversation

ericdstein
Copy link
Contributor

Add ability to set --force-build-metadata flag of /kaniko/executor.

A new flag --force-build-metadata was added to kaniko that forces layers with no files to be added to the image. One use case is keeping the layer that contains metadata of RUN USER.

@ericdstein ericdstein force-pushed the support_forcebuildmetadata_flag branch from f8cfa09 to a16143f Compare December 13, 2021 07:03
@kneal kneal added the feature Indicates a new feature label Dec 14, 2021
@kneal kneal changed the title allow setting --force-build-metadata flag for /kaniko/executor feat: allow setting --force-build-metadata flag for /kaniko/executor Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #102 (4fc42b9) into master (cbd08ec) will decrease coverage by 0.74%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   43.79%   43.05%   -0.75%     
==========================================
  Files           7        7              
  Lines         580      590      +10     
==========================================
  Hits          254      254              
- Misses        325      334       +9     
- Partials        1        2       +1     
Impacted Files Coverage Δ
cmd/vela-kaniko/image.go 100.00% <ø> (ø)
cmd/vela-kaniko/main.go 0.00% <0.00%> (ø)
cmd/vela-kaniko/plugin.go 93.49% <0.00%> (-2.34%) ⬇️

dtanner
dtanner previously approved these changes Jan 18, 2022
@ericdstein ericdstein marked this pull request as ready for review February 11, 2022 04:33
@ericdstein ericdstein requested a review from a team as a code owner February 11, 2022 04:33
Copy link
Contributor

@kaymckay kaymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the add 👍

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants