Library uses json.NewDecoder(body).Decode which might not error on trailing extra data

[mitar]

Version

0.9.2

Description

For example, in ParseCredentialCreationResponseBody you can see:

	var ccr CredentialCreationResponse

	if err = json.NewDecoder(body).Decode(&ccr); err != nil {
		return nil, ErrBadRequest.WithDetails("Parse error for Registration").WithInfo(err.Error())
	}

json.NewDecoder(r).Decode by itself is meant as a streaming parser and it does not fail on its own if there is trailing data after payload. I use such check in my own code to mitigate that.

Reproduction

N/A

Expectations

No response

Documentation

See: golang/go#36225

[james-d-elliott]

Yeah this seems fairly easy to add.

[mitar]

I think in general it would be useful to have also two defers:

defer body.Close()
defer io.Copy(io.Discard, body)

Just to make sure the body is drained and closed. (Improves connection reuse in Go http stack.)

[james-d-elliott]

This function is intentionally agnostic of what's being used. We can probably however add it to the non-agnostic one.