Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Commit

Permalink
Query add builder support (#829)
Browse files Browse the repository at this point in the history
  • Loading branch information
lunny committed Jan 18, 2018
1 parent 5185fdf commit afd1ab9
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 1 deletion.
12 changes: 11 additions & 1 deletion session_query.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,17 @@ import (

func (session *Session) genQuerySQL(sqlorArgs ...interface{}) (string, []interface{}, error) {
if len(sqlorArgs) > 0 {
return sqlorArgs[0].(string), sqlorArgs[1:], nil
switch sqlorArgs[0].(type) {
case string:
return sqlorArgs[0].(string), sqlorArgs[1:], nil
case *builder.Builder:
return sqlorArgs[0].(*builder.Builder).ToSQL()
case builder.Builder:
bd := sqlorArgs[0].(builder.Builder)
return bd.ToSQL()
default:
return "", nil, ErrUnSupportedType
}
}

if session.statement.RawSQL != "" {
Expand Down
47 changes: 47 additions & 0 deletions session_query_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
"testing"
"time"

"github.com/go-xorm/builder"

"github.com/stretchr/testify/assert"
)

Expand Down Expand Up @@ -183,3 +185,48 @@ func TestQueryNoParams(t *testing.T) {
assert.NoError(t, err)
assertResult(t, results)
}

func TestQueryWithBuilder(t *testing.T) {
assert.NoError(t, prepareEngine())

type QueryWithBuilder struct {
Id int64 `xorm:"autoincr pk"`
Msg string `xorm:"varchar(255)"`
Age int
Money float32
Created time.Time `xorm:"created"`
}

testEngine.ShowSQL(true)

assert.NoError(t, testEngine.Sync2(new(QueryWithBuilder)))

var q = QueryWithBuilder{
Msg: "message",
Age: 20,
Money: 3000,
}
cnt, err := testEngine.Insert(&q)
assert.NoError(t, err)
assert.EqualValues(t, 1, cnt)

assertResult := func(t *testing.T, results []map[string][]byte) {
assert.EqualValues(t, 1, len(results))
id, err := strconv.ParseInt(string(results[0]["id"]), 10, 64)
assert.NoError(t, err)
assert.EqualValues(t, 1, id)
assert.Equal(t, "message", string(results[0]["msg"]))

age, err := strconv.Atoi(string(results[0]["age"]))
assert.NoError(t, err)
assert.EqualValues(t, 20, age)

money, err := strconv.ParseFloat(string(results[0]["money"]), 32)
assert.NoError(t, err)
assert.EqualValues(t, 3000, money)
}

results, err := testEngine.Query(builder.Select("*").From("query_with_builder"))
assert.NoError(t, err)
assertResult(t, results)
}

0 comments on commit afd1ab9

Please sign in to comment.