Rename LICENSE to NOTICE & Add Apache Text in LICENSE #274
Conversation
|
LGTM, but I don't think we need the NOTICE file if we're adding the license explicitly. |
|
@niemeyer updated per your note. Was being very detailed. 😃 Should be good to merge now then. |
|
Thanks! |
|
@niemeyer This has removed the (Canonical) copyright statement - it's not anywhere anymore. The Apache license refers to the Copyright owner in its conditions, but it's now hard to track who the copyright owners are. It would be great for users of your library, like me, if you could restore the original Canonical copyright statement into a NOTICE file. I can submit a PR for this if you like. |
|
@dkoper the original NOTICE file was intended to resolve the issue you have. Tagging it back in should be very easy. I think the LICENSE.libyaml has to stay legally....I am probably wrong as an armchair licensing lawyer though. |
|
Tagging back would be great! Please let me know if you need me to submit a PR or issue to track it. Let me submit a separate issue on the LICENSE.libyaml - it's not really related as you point out. |
|
Added: #292 |
* v/fix-for-issue-91: (40 commits) Add test cases from go-yaml#184 Fix for issue go-yaml#91 Fixes go-yaml#214 - New option to allow setting strict boolean mode Fix for issue go-yaml#144 Always use the pointer mechanism, but only allow recursion per option Applied API changes as suggested in another PR and fixed outstanding problems Removed introduced shadowing bug Make aliases share the same memory address as the anchor ( go-yaml#215 ) Replace LICENSE text with actual license (go-yaml#274) Make tag scanning code slightly cleaner. move embedded struct example into godoc Add UnmarshalStrict returning error if yaml has fields that do not exist in structure correct misspell on yamlh.go fix misspell on emmiterc.go Remove unreachable code to fix go vet (go-yaml#249) Fix dead URL for yaml specification (go-yaml#240) Tighten restrictions on float decoding (go-yaml#171) Fix decode test for Go 1.8 (go-yaml#217) Fix unmarshaler handling of empty strings. new license in the README file (go-yaml#189) ...
This resolves #235