added a flag to indent or not indent the sequence #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2021
| @@ -0,0 +1 @@ | |||
| .vscode | |||
There was a problem hiding this comment.
VS Code is a popular editor. I was surprised that there was not a gitignore for this.
| func (s *S) TestSetIndentSequences(c *C) { | ||
| var buf bytes.Buffer | ||
| enc := yaml.NewEncoder(&buf) | ||
| enc.SetIndentSequences(false) |
There was a problem hiding this comment.
should there be a test for setting it to true?
There was a problem hiding this comment.
yes, it's actually true (well the inverse under the hood) by default so the above tests for sequences cover it. We can add an explicit set to true and make sure it works. It's not a bad idea.
This was referenced Jun 17, 2021
|
Superceded by @natasha41575 's #753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #720
This provides a function where one can set whether to indent or not indent the sequence. Not indenting the sequence provides a smoother upgrade path from v2 to v3. A lot of tools (like kustomize) would break their clients if the expected yaml differed.
If we expect more of these types of output configurations we should consider creating a formatting flags structure. Right now we just have the indent size and this flag, but maybe it will grow in the future. Happy to do either one, but my guess is that right now this is a stop gap for updates.
Review needed