Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the CI github action #137

Merged
merged 4 commits into from Nov 9, 2022
Merged

Improve the CI github action #137

merged 4 commits into from Nov 9, 2022

Conversation

bartekpacia
Copy link
Contributor

@bartekpacia bartekpacia commented Nov 6, 2022

Simplified the workflow and added verifying that code is formatted with gofmt.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 67.38% // Head: 67.54% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (1d0e21e) compared to base (7197359).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   67.38%   67.54%   +0.16%     
==========================================
  Files          29       29              
  Lines        1821     1821              
==========================================
+ Hits         1227     1230       +3     
+ Misses        491      489       -2     
+ Partials      103      102       -1     
Impacted Files Coverage Δ
conn.go 56.32% <0.00%> (+1.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Co-authored-by: Sebastien Binet <binet@cern.ch>
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet sbinet merged commit 2ae9328 into go-zeromq:main Nov 9, 2022
@bartekpacia bartekpacia deleted the ci/improve_gh_action branch November 9, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants