Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconnect if failed #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reconnect if failed #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,9 @@ func (c *Conn) loop(ctx context.Context) {
for {
if err := c.connect(); err != nil {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connect seems to only return an error when c.shouldQuit is set. connect already has a reconnect loop as well, so I am not sure this will do what you want it to do.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case: zk server startup AFTER zk client

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connect() failed and then RETURN loop()

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help explain this a bit more for me. I am sure you are right, but I am not picturing the scenario.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also any unittest here would be good. The logic here is not trivial and a unittest could document the issue as well protect against regressions

// c.Close() was called
return
c.logger.Printf("connect failed: %s", err)
time.Sleep(time.Second)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem arbitrary? Why one second?

continue
}

err := c.authenticate()
Expand Down