Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for goToMain/c-utils#15 #16

Merged
merged 1 commit into from Feb 5, 2021
Merged

Fix for goToMain/c-utils#15 #16

merged 1 commit into from Feb 5, 2021

Conversation

patrick-compass
Copy link
Contributor

No description provided.

@patrick-compass patrick-compass mentioned this pull request Feb 5, 2021
Merged
sidcha
sidcha requested changes Feb 5, 2021
View reviewed changes
Copy link
Member

@sidcha sidcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The commit message should include the reason for this change. Not just the issue ID as we want the git logs to indicate the reason for any change.

Just "utils.c/hexdup() does not print string when length is exactly 16" would be enough.

src/utils.c Outdated Show resolved Hide resolved
@sidcha sidcha merged commit f2d83e4 into goToMain:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidcha sidcha sidcha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrick-compass @sidcha