Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support full project CRUD #201

Merged
merged 2 commits into from
Feb 15, 2020
Merged

feat: support full project CRUD #201

merged 2 commits into from
Feb 15, 2020

Conversation

bitpshr
Copy link
Contributor

@bitpshr bitpshr commented Jan 7, 2020

This pull request updates the API transport by adding support for project creation, updating, deletion, archiving, and unarchiving.

Requires https://github.com/goabstract/projects/pull/3841
References #180

@tommoor
Copy link
Contributor

tommoor commented Jan 8, 2020

Unfortunately we can't enable project creation via the SDK until the underlying repository is setup entirely server-side, currently the API endpoint relies on the fact that the desktop client will create the repository with a PROJECT_CREATED commit and push that to the server.

I think we'll need a new API version that enables gitnode to perform this operation, rather than the client, and then use that API version here before it's mergeable.


I do think this is important though, so lets figure out a path to move forward – whether it's yourself doing the gitnode work or if we need to grab one of the platform engineers for a few days.

@bitpshr
Copy link
Contributor Author

bitpshr commented Jan 8, 2020

Ah, thanks for this @tommoor. I will try to get the gitnode stuff in place.

@tommoor
Copy link
Contributor

tommoor commented Jan 27, 2020

Removing review request until backend is ready.

@tommoor tommoor removed their request for review January 27, 2020 18:01
@amccloud amccloud removed their request for review January 27, 2020 19:37
@bitpshr bitpshr changed the base branch from feat/raw-response to master February 14, 2020 18:05
@bitpshr
Copy link
Contributor Author

bitpshr commented Feb 14, 2020

Ready for another pass now that the backend changes are live and the API version has been bumped @tommoor. Thanks in advance!

Copy link

@bfields06 bfields06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to pull down and CRUD projects locally.

@bitpshr bitpshr merged commit a000ca6 into master Feb 15, 2020
@bitpshr bitpshr deleted the feat/project-crud branch February 15, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants