Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use application/json for Content-Type header in health handler #221

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

douglaswth
Copy link
Member

No description provided.

@douglaswth douglaswth requested a review from raphael April 28, 2023 18:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #221 (30b3193) into main (4aafcf6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          43       43           
  Lines        2182     2183    +1     
=======================================
+ Hits         2058     2059    +1     
  Misses         91       91           
  Partials       33       33           
Flag Coverage Δ
micro 94.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
health/handler.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael
Copy link
Member

raphael commented Apr 28, 2023

This is great, thank you!

@raphael raphael merged commit 931027d into main Apr 28, 2023
@raphael raphael deleted the douglaswth/health-json-content-type-header branch April 28, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants