Fix mock generation of function pointer signature parameters #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix an interface method with a parameter such as `func(goa.Endpoint)` would be generated as `func(goa.design/goa/v3/pkg.Endpoint)` instead of something that is actually valid Go.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 94.31% 94.32%
=======================================
Files 43 43
Lines 2183 2186 +3
=======================================
+ Hits 2059 2062 +3
Misses 91 91
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
douglaswth
deleted the
douglaswth/fix-mock-function-pointer-signature-generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix an interface method with a parameter such as
func(goa.Endpoint)would be generated asfunc(goa.design/goa/v3/pkg.Endpoint)instead of something that is actually valid Go.