Fix Clue Mock Gen package name conflict #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a bug where an alias is not used for the mocked package if it conflicts with one of the other intial imports (this was discovered with a package named `testing`, but it looks like it could also come up if it was named `mock` which would conflict with `goa.design/clue/mock`. - Bump version so it will be correct for a new release.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 94.33% 94.33% -0.01%
==========================================
Files 43 43
Lines 2189 2187 -2
==========================================
- Hits 2065 2063 -2
Misses 91 91
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing, but it looks like it could also come up if it was namedmockwhich would conflict withgoa.design/clue/mock.