Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change godoc of metrics.RouteResolver from httptreemux to chi #302

Merged
merged 1 commit into from Oct 13, 2023

Conversation

tchssk
Copy link
Member

@tchssk tchssk commented Oct 7, 2023

Related to goadesign/goa#3346

from httptreemux to chi.
@codecov-commenter
Copy link

Codecov Report

Merging #302 (3203637) into main (1cf62e8) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files          43       43           
  Lines        2338     2338           
=======================================
  Hits         2204     2204           
  Misses         98       98           
  Partials       36       36           
Flag Coverage Δ
micro 94.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
metrics/options.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael
Copy link
Member

raphael commented Oct 13, 2023

Whoops - nice catch, thank you!

@raphael raphael merged commit dca46ea into goadesign:main Oct 13, 2023
1 check passed
@tchssk tchssk deleted the metrics-routeresolver-godoc-chi branch October 14, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants